-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Populate topics from Gitlab #887
Open
sponte
wants to merge
9
commits into
mvisonneau:main
Choose a base branch
from
HO-CTO:feature/read-gitlab-project-topics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit propages the topics from Gitlab project response into prometheus stats Fixes mvisonneau#697
sponte
changed the title
fix: Populate topics from Gitlab
DRAFT fix: Populate topics from Gitlab
Sep 3, 2024
sponte
changed the title
DRAFT fix: Populate topics from Gitlab
fix: Populate topics from Gitlab
Sep 3, 2024
The projects are read from the config, but retrieved from Gitlab through pull configuration. This is to enable scraping of the configuration data e.g. Topics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes are included in this PR:
config.Projects
similarly to howconfig.Wildcards
work - previously the projects configuration was not validated directly in Gitlab and hence the topics were not retrieved.PullProjects
, but it does inPullProjectsFromWildcards
)Fixes #697